[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Was: Enhancement needed in svn status -u

From: Mark Phippard <MarkP_at_softlanding.com>
Date: 2005-08-23 15:24:13 CEST

Paul Burba/SoftLanding Systems wrote on 08/22/2005 06:08:56 PM:

> One known problem with the patch: It doesn't pick up the last committed
> author and date for a WC item that has been deleted in the repository.
> anyone has suggestions on this front I'd love to hear them.

I am the one that asked for this patch, as we *really* need this extra
information in Subclipse via JavaHL. We currently only truly need the
last changed revision and the URL in Subclipse. However having the author
and date available could potentilly be nice to have in the long term. But
my main point is that if the only scenario where this info is not
available is a delete from the repository, then that would not cause us
any problems. In that scenario, all we really need in Subclipse is the

> Index: subversion/include/svn_wc.h
> ===================================================================
> --- subversion/include/svn_wc.h (revision 15823)
> +++ subversion/include/svn_wc.h (working copy)
> @@ -1516,6 +1516,29 @@
> /** The entry's lock in the repository, if any. */
> svn_lock_t *repos_lock;
> + /** Out of Date Info.
> + *
> + * If the working copy item is out of date compared to the repository
> + * the following five fields represent the HEAD state of the item in
> + * the repository. If not out of date, the items are set as
> + * below.
> + */

This comment has me a bit confused because of the use of the term HEAD. I
am assuming the information that will be passed back is about the last
revision when the item was committed, which may or many not currently be
the HEAD revision of the repository? Your variable names would imply that
is the case. Of course, this only applies to the revision number itself
as the other values would be the same. In Subclipse, ideally we would be
receiving the revision number of the last commit. And this is because we
are using that value as a "key" to a cache variable.

> +
> + /* If not out of date set to SVN_INVALID_REVNUM. */
> + svn_revnum_t ood_last_cmt_rev;
> +
> + /* If not out of date set to 0. */
> + apr_time_t ood_last_cmt_date;
> +
> + /* If not out of date set to svn_wc_status_none. */
> + svn_node_kind_t ood_kind;
> +
> + /* If not out of date set to NULL. */
> + const char *ood_url;
> +
> + /* If not out of date set to NULL. */
> + const char *ood_last_cmt_author;
> +
> } svn_wc_status2_t;



Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 23 15:26:07 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.