Re: svn_client_commit_item_t.revision reused for different things

"C. Michael Pilato" <cmpilato@collab.net> writes:
> Ivan Zhakov <chemodax@gmail.com> writes:
>
> > Hi!
> > I am working on wc-replacement branch and notice strange thing:
> > In file subversion\include\libsvn_client.h line 270:
> > /** The commit candidate structure. */
> > typedef struct svn_client_commit_item_t
> > {
> > [..skip..]
> > /** revision (copyfrom-rev if _IS_COPY) */
> > svn_revnum_t revision;
> >
> > /** copyfrom-url */
> > const char *copyfrom_url;
> > [..skip..]
> > } svn_client_commit_item_t;
> >
> > As comment states member revision used as base revision and
> > copyfrom-revision, depending on copyfrom-url. For what is it? In
> > situation replace from copy, repository need to know original file
> > revision (for delete it) and copyfrom revision (for copy). I suggest
> > add separate member copyfrom_rev and get rid ambiguity.
>
> +1. Makes sense. Knock yerself out.
                     ^^^^^^^^^^^^^^^^^

Ivan, I don't know how good your command of American idiom is :-). In
case you don't know: "knock yerself out" just means "go for it".

-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org