Re: [PATCH] psvn: Bind a free variable, and mark an intentionally dynamic binding as such.

Kalle Olavi Niemitalo <kon@iki.fi> writes:

> Erik Huelsmann <ehuels@gmail.com> writes:
>
>> Please include xsteve@tigris.org (the author) in your next submission.
>> He isn't monitoring dev@ closely.
>
> I did when I posted the patch, but I don't think he'd care about
> discussions on whether to file an issue, especially if the issue
> will not be filed.
>
> I have now committed the better changes as revision 15841.

Thanks. And thanks also for your other patches that improved the code
quality.

> There is still something odd about svn-parse-status-result.
> It binds user-mark and user-elide to nil, and then possibly
> stores (list user-mark user-elide) to ui-status. However, it
> never changes user-mark and user-elide; they remain nil at all
> times. Is there a hidden meaning here, or should I just remove
> those variables and use (list nil nil) instead?

The variables just serve as documentation. You could use (list nil
nil) and put a comment that the values have the meaning of user-mark
and user-elide.

> I'd also like to remove the ui-status variable (to eliminate the
> excessive scope and the misleadingly literal initial value) and
> replace its sole use with the (or ...) expression from which the
> true value always comes.

ui-status was also meant as documentation. It should keep the user interface.
We could add some more data that is tracked for the user interface.
That would be stored also in this list.

You can remove that variable if you want. But please put add some
documentation to describe, that this part holds the user interface state.

Stefan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 21 22:16:06 2005