Re: [PATCH] notification callbacks for network data transfers (V2)

Stefan Küng wrote:

> New patch which uses Branko's comments to fix what was broken.
>
> Branko Čibej wrote:
>
>>> +static void
>>> +svn_ra_dav__neonprogress(void * baton, off_t progress, off_t total)
>>> +{
>>> + const svn_ra_callbacks_t * callbacks = (svn_ra_callbacks_t *)baton;
>>>
>>>
>> You don't need the cast here. Sorry, couldn't resist the style nit. :)
>
> I know the cast is not needed. But the VS.NET compiler throws out a
> warning if there's no cast (but only with /W4)

I don't think /W4 is ever useful for production...

> and there's no harm to have the cast (?), so I thought I leave it there.

Don't get me started on unnecessary casts. I could go on for hours. :)

> Feel free to remove it though.

Will do. Casts are evil.

Looks good, but I'll need some time to review in detail.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 19 22:42:12 2005