[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

svn_client_commit_item_t.revision reused for different things

From: Ivan Zhakov <chemodax_at_gmail.com>
Date: 2005-08-19 17:29:43 CEST

I am working on wc-replacement branch and notice strange thing:
In file subversion\include\libsvn_client.h line 270:
/** The commit candidate structure. */
typedef struct svn_client_commit_item_t
  /** revision (copyfrom-rev if _IS_COPY) */
  svn_revnum_t revision;

  /** copyfrom-url */
  const char *copyfrom_url;
} svn_client_commit_item_t;

As comment states member revision used as base revision and
copyfrom-revision, depending on copyfrom-url. For what is it? In
situation replace from copy, repository need to know original file
revision (for delete it) and copyfrom revision (for copy). I suggest
add separate member copyfrom_rev and get rid ambiguity.

Ivan Zhakov
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 19 17:37:14 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.