Re: need inputs on issue#443

On Fri, 19 Aug 2005, Madan U Sreenivasan wrote:

> On Thu, 2005-08-18 at 14:26, Peter N. Lundblad wrote:
> > On Wed, 17 Aug 2005, Madan U Sreenivasan wrote:
> [snip]
> > I propose moving svn_client_commit_info2_t to svn_types.h and calling it
> > svn_commit_info_t (you don't need to rev any APIs since that's new). Then
> > rev svn_commit_callback_t to take a const svn_commit_info_t * (and a
> > baton, and why not a scratch pool while we are here (see issue #1881)). I
> good idea overall. Thx.
> I dont know the scratch pool funda. Do you mean that the callback should
> take a pool as a parameter?

Yes, for temporary allocations only. Mostly for consistency in this case.

> > know that this will mean reworking some of your previous patches, but I
> > think that's the cleanest solution.
> sadly, yes, but its okay if we can get some long term leverage because
> of this.
> >
> > We all love API revving, don't we?
> really? ;)
>

Nope. :-)

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 19 13:08:53 2005