[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] avoid memory reallocation

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2005-08-19 10:53:07 CEST

On 8/18/05, Peter N. Lundblad <peter@famlundblad.se> wrote:
> On Thu, 18 Aug 2005, Michael W Thelen wrote:
> > SteveKing wrote:
> > > This is really a *very* little thing:
> > >
> > > The CL client uses an array to store all the auth providers. The initial
> > > size of that array is set to 10, but on Windows, there's one auth
> > > provider more so the array is always reallocated (or I'm counting wrong,
> > > could happen too).
> > > This very little patch takes care of this.
> >
> > Pinging this patch... Brane objected, saying that it's not worth the
> > bother to change the initial size whenever a new auth provider is added.
> > Steve responded that new auth providers are not added often, and the
> > initial size already seems to be intended to accommodate all auth
> > providers, which it doesn't quite do on Windows.
> >
> I think this can be fixed the next time we add a provider.

Given that there already is a patch, why postpone?
> But you're right that there is nothin gwrong with it.

Ok. In that case, anybody object if I commit the patch tonight?



To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 19 10:54:06 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.