[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15799 - trunk/subversion/include

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2005-08-19 04:29:33 CEST

Branko Čibej wrote:
> Garrett Rooney wrote:
>> Branko Čibej wrote:
>>> But first of all, the correct way to go about this is to use the APR
>>> macros if they're available: therefore,
>>> #ifndef APR_ARRAY_IDX
>>> #define APR_ARRAY_IDX ...
>>> Etc.
>> Well, it sure seems like 6 of one, half dozen of the other to me, but
>> if you want it done that way I have no objection. Feel free to commit
>> the change, or if you don't get around to it I'll take a look tonight
>> when I get home from work.
> The significant bit you're missing here is that the definitions of the
> macros in APR _could_ change in the future, so we certainly want to use
> the APR macros if they're available.

I find it difficult to imagine these macros being changed in a manner
that would not result in a non-compatible change in the interface
itself, which would result in massive changes to the parts of the tree
that don't use the macros, but hey, if it's as unlikely as it seems to
be then it makes no difference which version we use, so we might as well
use the APR versions.

> I'm horribly busy today, so you'll probably get to make the change
> before I do...

Committed in r15815.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 19 04:30:18 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.