[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: File Locking on Win9x, and FSFS repositories

From: Max Bowsher <maxb_at_ukf.net>
Date: 2005-08-19 01:03:16 CEST

Ben Collins-Sussman wrote:
> On Aug 18, 2005, at 11:18 AM, Max Bowsher wrote:
>> I'd appreciate comments from anyone who understands the situation
>> better, and if anyone has a Win9x machine on which they could check
>> that this makes file:/// access to FSFS repositories work, that
>> would be great - although please take note that this is just quick
>> hack, and my assumption that FSFS doesn't need this locking might
>> possibly be incorrect.
>> Max.
> Interesting approach. I was discussing this problem with ghudson
> last week in IRC, and was planning to fix it in a very different
> way. ghudson pointed out that it's a design mistake that the
> svn_repos_open() tries to do any locking at all. My thought was that
> the bdb shared-lock should be an implementation detail of
> libsvn_fs_bdb; I was planning to push the shared-lock code down into
> the bdb implementation of svn_fs_open().

If not for compatibility, yes, that would be the way to do it, BUT there is
a problem. The lockfile is located outside the db/ directory, which is the
the "fs" which is handled by libsvn_fs. In other words, a svn repository is
a libsvn_fs FS nested within a libsvn_repos "repos", and it would be a
violation of the layered design for the inner layer to assume things about
the implementation of the outer layer.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 19 01:04:07 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.