[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix to svnperms.py to allow regex's that start with '['

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-08-18 20:21:48 CEST

Marc Sherman wrote:

> Michael W Thelen wrote:
>> Any objections to this patch being applied? I'll file it as a patch
>> issue in a day or two if no one comments.
> Well, the patch would conflict with my pending patch to add section
> inheritance... is that grounds for an objection? How are conflicting
> patches for unreleated issues usually handled on this list? Is it up
> to the submitter of whichever one doesn't get applied first to
> resubmit a new patch?

In general, yes. Of course, that doesn't mean that patch contributors
shouldn't talk to each other and coordinate their changes. :)

Anyway, as I said before, I don't see a good reason why this patch
should be applied, given that there's a simple workaround.

Regarding section inheritance: I see you proposed a syntax that looks
like this:

    [section] inherits [parent]

I don't like that. I'd really prefer it if svnperms.py started using
ConfigParser for parsing the config file. There's nothing in the current
config file that would prevent that, but if you add this syntax, the
game's over.

I'm not saying you should make this change yourself, only that any
syntax change should maintain ConfigParser compatiblity.

Since you already have magic section names, i.e., [section groups], you
could define inheritance in a similar way. For example:

    [section extends parent]

-- Brane

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 18 20:23:03 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.