[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix to svnperms.py to allow regex's that start with '['

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-08-18 19:49:53 CEST

Michael W Thelen wrote:

>Chris Leishman wrote:
>>The '[' character is a legitimate start to a regular expression - for
>>example in '[^/]+/tags' to match a tags directory inside any single
>>parent directory. Unfortunately, the regex match for section headers
>>treats such a regex as the start of a new section (named '^/').
>>This patch fixes that behaviour by making the section match check that
>>nothing follows the section header on the line.
>Thanks for the patch. It looks like no one has reviewed or commented on
>this patch since it was posted. I don't know Python, but knowing Perl
>regular expressions, it looks like this change simply allows regular
>expressions beginning with [ not to be misrecognized as section headers.
> Of course, regular expressions consisting entirely of a single
>character class will still be interpreted as section headers. But that
>doesn't seem like a very likely regular expression to be used in the
>permissions config file.
>Any objections to this patch being applied? I'll file it as a patch
>issue in a day or two if no one comments.
Why can't one just write ([x]) instead of [x]? It matches the same thing.

Also, I can't help wondering why svnperms.py parses its config file
itself instead of using Python's ConfigParser...

-- Brane

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 18 19:55:43 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.