Re: [svk-dev] [PATCH] to fix Subversion 1.2.x perl binding build on Win32

On 8/18/05, Chia-liang Kao <clkao@fotango.com> wrote:> > Branko Čibej wrote:> >>> Can someone with win32 try this patch?> >>>> >>> The problem is that win32 binaries are not built with correct> >>> reporter.hi generated by h2i, which is usually invoked by> >>> Makefile.PL.> >>>> >>> >>> >> I can test the build, but don't know anything about testing the> >> bindings themselves.> >>> >> > It looks like recent changes on the python improvements branch make> > change this obsolete.> > But can we port the build part to 1.2.x? or can you run Makefile.PL> to regen ra_reporter.hi properly when building win32 package? :)If Kevin's changes to build/generator/gen_win.py fix the build onWin32, then I think we should port them to 1.2.x.
Kevin made changes to other files, too. These are unnecessary, becausethey are autogenerated by gen-make.py:* build/win32/msvc-dsp/swig_perl_client_msvc.dsp* build/win32/msvc-dsp/swig_perl_core_msvc.dsp* build/win32/msvc-dsp/swig_perl_delta_msvc.dsp* build/win32/msvc-dsp/swig_perl_fs_msvc.dsp* build/win32/msvc-dsp/swig_perl_ra_msvc.dsp* build/win32/msvc-dsp/swig_perl_repos_msvc.dsp* build/win32/msvc-dsp/swig_perl_wc_msvc.dsp
As brane says, the change to Core.pm looks like it was included accidentally.* subversion/bindings/swig/perl/native/Core.pm
Other than that, if the patch works, I think it would be a good ideato port it to 1.2.x. You can even commit it to trunk, if you do thisbefore I merge python-bindings-improvements back to trunk.
Cheers,
David
P.S. I'm hoping to merge python-bindings-improvements to trunk this weekend. See http://svn.haxx.se/dev/archive-2005-08/0624.shtml
-- David James -- http://www.cs.toronto.edu/~james
Received on Thu Aug 18 14:12:29 2005