Chia-liang Kao wrote:
> Can someone with win32 try this patch?
>
> The problem is that win32 binaries are not built with correct
> reporter.hi generated by h2i, which is usually invoked by Makefile.PL.
I can test the build, but don't know anything about testing the bindings
themselves.
>> This patch is against the root of the Subversion-1.2.1.zip release.
>
I wish people would post patches against HEAD...
>> * build/generator/gen_win.py
>> * build/win32/msvc-dsp/swig_perl_client_msvc.dsp
>> * build/win32/msvc-dsp/swig_perl_core_msvc.dsp
>> * build/win32/msvc-dsp/swig_perl_delta_msvc.dsp
>> * build/win32/msvc-dsp/swig_perl_fs_msvc.dsp
>> * build/win32/msvc-dsp/swig_perl_ra_msvc.dsp
>> * build/win32/msvc-dsp/swig_perl_repos_msvc.dsp
>> * build/win32/msvc-dsp/swig_perl_wc_msvc.dsp
>
YUCK! What's with patching generated DSP's?
>> === subversion/bindings/swig/perl/native/Core.pm
>> ==================================================================
>> --- subversion/bindings/swig/perl/native/Core.pm (revision 1)
>> +++ subversion/bindings/swig/perl/native/Core.pm (patch
>> Win32SubversionPerlSWIGFix level 1)
>> @@ -3,8 +3,7 @@
>>
>> package SVN::Core;
>> use SVN::Base qw(Core svn_ VERSION);
>> -$SVN::Core::VERSION = "$SVN::Core::VER_MAJOR. $SVN::Core::VER_MINOR." .
>> - "$SVN::Core::VER_MICRO";
>> +$SVN::Core::VERSION = "$SVN::Core::VER_MAJOR.
>> $SVN::Core::VER_MINOR." . "$SVN::Core::VER_MICRO";
>>
>> =head1 NAME
>
This change looks like total nonsense to me.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 18 05:40:06 2005