Re: [PATCH] V2, diff preview without text deltas

steveking wrote:
> Martin Hauner wrote:
>
>> +/** a struct that describes the diff of an item. Passed to
>> + * svn_diff_preview_func_t.
>> + *
>> + * @since New in 1.3.
>> + */
>> +typedef struct svn_diff_preview_t
>> +{
>> + /** file or dir */
>> + svn_node_kind_t node_kind;
>> +
>> + /** item paths, relative to the old diff target and new diff target */
>> + const char* path_old;
>> + const char* path_new;
>> +
>> + /** change kind: unchanged, added, modified or deleted */
>> + svn_diff_preview_kind_t preview_kind;
>> +
>> + /** properties changed? */
>> + svn_boolean_t props_changed;
>> +
>> +} svn_diff_preview_t;
>
>
> Question: how would I find out if *only* the properties have changed and
> not the file contents too?
> Wouldn't it be better to have two booleans there, one indicating a
> change in properties and one indicating a change in text content?

preview_kind set to unchanged
props_changed set to true

But i like the idea with the second bool. It would be more consistent
with the way it is handle by svn status and i guess it is easier to
understand too.

I will change it in the next version.

-- 
Martin
Subcommander, http://subcommander.tigris.org
a cross platform Win32/Unix/MacOSX subversion gui client & diff/merge tool.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org