[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] storing auth after auth failure

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-08-12 10:53:29 CEST

Philip Martin wrote:

>Branko Čibej <brane@xbc.nu> writes:
>
>
>
>>>- if (! state)
>>>+ if (! state || state->table->providers->nelts == state->provider_idx)
>>> return SVN_NO_ERROR;
>>>
>>>
>>>
>>>
>>I think we should go ahead and store the auth info anyway, as I do in
>>my patch.
>>
>>
>
>Hmm, as far as I can see your patch doesn't store the auth info
>either. I don't mind which patch you commit as I think they have the
>same effect :)
>
>
Your patch makes save_creds bail out if the initial provider index is
out of range. My patch just skips the initial creds save with the
"default" provider, but still goes through the loop -- which,
presumably, will save the authn info.

Maybe we can toss a coin to decide which patch goes in. :)

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 12 10:54:28 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.