On 8/11/05, Ben Reser <ben@reser.org> wrote:
> On Thu, Aug 04, 2005 at 11:18:11AM -0500, kfogel@collab.net wrote:
> > David, some good news: Ben Reser has agreed to look these over in the
> > next few days. (And thank you, Ben!)
> >
> > Since there's no reason to be mysterious about the goal here, I'll
> > just say it out loud: this is a bootstrap review, the purpose of which
> > is to be able to say "Hey, this David James guy knows his way around
> > the Python bindings, so we should just give him commit access there,
> > so he doesn't need to wait on others to commit bindings trunk changes
> > from now on."
> >
> > Obviously, if Ben finds any serious problems, he'll raise questions
> > here, and we'll work them out. I'm unfortunately not experienced
> > enough with the Python bindings to review the changes themselves, but
> > I looked over your log messages and saw nothing alarming. They were
> > clear, well-formatted, referred to previous changes where appropriate,
> > etc. And the general direction of the changes seems very good,
> > needless to say.
> >
> > Thanks also for this summary mail, which really packaged things up in
> > an easy-to-comprehend way for potential reviewers.
>
> I've completed my review. I don't really see any problems. Though I
> only reviewed a lot of it in a very cursory way since it is very
> specific to Python internals or SWIG specific to Python.
Great! Thanks for your help, Ben!
On 8/11/05, Ben Reser <ben@reser.org> wrote:
> I've completed my review. I don't really see any problems.Though I
> only reviewed a lot of it in a very cursory way since it is very
> specific to Python internals or SWIG specific to Python.
Oops! Hopefully our shiny new test suite will help prevent this in future :)
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 11 22:12:51 2005