Re: [PATCH] svncopy.pl fails with spaces in file paths.

Charles Bailey wrote:
> On 8/9/05, Michael W Thelen <mike@pietdepsi.com> wrote:
>
>>- my @commandline = ( $svn, $command, @svn_options, @options );
>>+ my @commandline = ( $svn, $command, @svn_options, map {"\"$_\""}
>>@options );
>
> Would you do better by using quotemeta() rather than plain quotes?

I don't think so, since we're not trying to quote regular expression
special characters, and quotemeta doesn't escape spaces.

However, this brings up an interesting issue... the patch does not
address any special characters at all (like $ on Linux, % on Windows,
etc.). It also doesn't escape double quote characters themselves, if
they appear in the arguments. For now, this patch punts on those issues
(and maybe punting is good enough, I don't know).

-- 
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org