[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 443: post-commit hook (error) output lost: Step 1

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-08-09 12:04:38 CEST

On Wed, 3 Aug 2005, Julian Foad wrote:

> Hi,
> Pl. find attached the step-1 of the patch for issue #443. These steps

A tweaked version was committed in r15648.

The tweaks were docstring for the most part. I moved
svn_client_commit_info2_t above the soon-to-be-deprecated function and
added a @since note, and I moved the constructor below the constructor for
the client context.

The important thing I changed was that the constructor now initializes the
fields of the struct. the reason is that old code must be able to use the
constructor even if the struct has been extended and the new fields must
then be initialized. (Note that this constructor isn't used, but it is
still a good idea to provide a constructor, so that people don't start
creating objects themselves.)

Thanks for the patch,

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 9 12:05:49 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.