[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add authz support to the commit editor

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2005-08-04 22:41:20 CEST

This patch looks good, and I will likely commit it this evening with an
s/revv/rev/ in the log message.

Your testing methodology runs afoul of this part of the editor API:

 * At least one implementation of the editor interface is
 * asynchronous; an error from one operation may be detected some
 * number of operations later. As a result, an editor driver must not
 * assume that an error from an editing function resulted from the
 * particular operation being detected. Moreover, once an editing
 * function returns an error, the edit is dead; the only further
 * operation which may be called on the editor is abort_edit.

But since we're always testing over file:/// and this is part of the
test suite, I think that's okay. I may add a comment.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 4 22:43:50 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.