[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] Fix svn issue #2269 - warn and skip for nonexistent file

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-08-04 20:36:07 CEST

Alexander Thomas wrote:
> Patch to fix svn issue #2269 - warn and skip for nonexistent file
> on 'svn rm' and exit with failure.

Thanks for working on this.

> Patch is still incomplete respect to the expected behavior and also its
> a stupid patch, if implemented will fail almost all test. :-). This
> patch is only meant for discussion and suggestion and not for review.

OK, well, what's good or interesting about this patch? I haven't formed an
opinion, I'm just asking because you're only saying negative things about it.
What do you want to discuss? Do you understand what behaviour is required in
enough detail to implement it?

> What I tried to do is, when a target is nonexistent
> svn_wc_adm_open_anchor() will return with an error. Its a very common
> function used in many svn commands, so this behavioral change will
> trigger almost all test to fail.

Alexander, you would probably get a response if you tell us what you are
thinking and ask specific questions. Do you think this is the best way to
address the problem, and all the other callers of that function can be updated
in some predictable way, or should the tests be failing because they are wrong,
or what? Are you just throwing out some half-baked ideas? Have you hit a
conceptual problem, or a practical problem, or are you still working on this?
Tell, and ask, or propose ideas, and we'll answer or discuss.

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 4 20:38:41 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.