[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r15584: streamy API for retrieval of file contents

From: Daniel L. Rall <dlr_at_finemaltcoding.com>
Date: 2005-08-04 09:54:25 CEST

On Thu, 2005-08-04 at 10:58 +1000, Peter McNab wrote:
> Daniel Rall wrote:
> >Patrick, I've committed Conor's patch which adds a streamy API for
> >retrieval of versioned file contents. Since the patch refactors the
> >native implementation of the SVNClient.fileContent() method (rather than
> >adding a new API without changing any of the current implementation),
> >you may want to review this change. I both reviewed Conor's patch and
> >made some incidental modifications to it, and assured it passes 'make
> >check-javahl', but an extra set of eyes never hurts.
> >
> >Also, I was wondering if the name "writeFileContent" might be more clear
> >than "streamFileContent" (though the later certainly declares the
> >streamy nature of the implementation).
> >
> >- Dan
> >
> >
> >
> How about streamwriteFileContent?

Thanks for the suggestion, Peter. A little verbose, I think. Also, the
use of two running verbs doesn't make for the cleanest method name.

- Dan

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 4 09:55:15 2005

This is an archived mail posted to the Subversion Dev mailing list.