[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] check name svn special properties

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2005-08-02 17:02:44 CEST

David Weintraub wrote:
> Just curious...
>
> I just started reading this whole discussion. Couldn't all of this
> checking be added to a pre-commit hook? I already have a hook that
> verifies that particular properties are added and are in the correct
> format. It would be very simple enhance the hook to forbid svn:*
> properties that aren't valid.

Of course a pre-commit hook could check this, but that would only take effect
when I try to commit. I might have added a new file, set its properties, been
editing and compiling it, and perhaps noticing or perhaps not noticing that the
EOL style or ignores or whatever aren't working properly, and I wouldn't get
the benefit of the checking until I am ready to commit, by which time I have
either noticed the problem and debugged it without Subversion's help, or not
noticed that there was a problem.

Secondly, it is natural and right that a program should check its own input.
There is some disagreement about whether this input (of "svn:*" property names)
to the svn client really "belongs to" the svn client in the sense of the client
knowing what is valid, or whether this input belongs more to the overall
Subversion multi-client/server system, but to a large extent it is the former
as long as there is a mechanism (--force) for entering other names in the
occasional exceptional cases.

A pre-commit hook is certainly a valid work-around.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 2 17:03:59 2005

This is an archived mail posted to the Subversion Dev mailing list.