Re: [PATCH] new feature: takeover

Ben Collins-Sussman wrote:
> On Aug 1, 2005, at 8:34 AM, Mark Phippard wrote:
>>
>> Are you against the feature altogether, or just the idea of a new
>> subcommand? I believe all of the discussion on this feature has
>> gravitated towards it being a new option on the checkout command instead
>> of a command in its own right.
>
> My feelings are
>
> 1. this is a good idea, a useful new feature. very much in demand.

+1.

> 2. it should be a switch, not a subcommand.

+1.

I say it should be part of the behaviour of "--force" which currently means:

   Take over any directories here that are already in the repository;
   leave alone any directories and files here that are not in the repository.
   (Abort if there are any files here that are already in the repository.)

Its new meaning would simply add "and files" to the first clause, regularising
the behaviour for files:

   Take over any directories and files here that are already in the repository;
   leave alone any directories and files here that are not in the repository.

Isn't that accurate and lovely?

> 3. it should not reimplement rsync, it should just re-download the
> *whole* file in those cases where the local checksum doesn't match the
> server's checksum.

+1. Note, however, that an implementation that avoids downloading a file if
the checksum does match is not currently offered. I'm still +0.5 even with it
downloading every single file, because that still provides the functional
benefit. It should be possible to add the checksum comparison at some later
date, as a backward-compatible upgrade, to give a great speed benefit.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Aug 1 23:50:27 2005