[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix memory leak like situation when parsing a svn_config_t object repeatedly

From: Bernd Rinn <bernd_at_sdf.lonestar.org>
Date: 2005-07-31 20:34:49 CEST

Here is the simplified patch.

Bernd Rinn wrote:
> Greg Hudson wrote:
>
>>On Fri, 2005-07-29 at 01:57 +0200, Bernd Rinn wrote:
>>
>>
>>>>>Since creating a new pool adds overhead, I feel that the caller of
>>>>>svn_config_enumerate2() & co. should have a choice on whether an
>>>>>iteration pool is to be created or not. That's controlled by the value
>>>>>of the argument create_iteration_pool.
>>
>>
>>I agree with Julian that this is too many knobs. We normally create
>>subpools with impunity.
>
>
> Since there is obviously a firm and common understanding about memory
> pool creation in the project, removing the create_iteration_pool
> argument seems to be the way to go.

-- 
Bernd Rinn


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sun Jul 31 20:35:37 2005

This is an archived mail posted to the Subversion Dev mailing list.