[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit in mixed checkout doesn't create locks recursively, and fails

From: David Faure <faure_at_kde.org>
Date: 2005-07-31 12:28:39 CEST

On Wednesday 29 June 2005 18:21, Philip Martin wrote:
> David Faure <faure@kde.org> writes:
>
> > proko2/kdepim>svn ci korganizer kontact/src/main.cpp
> > svn: Commit failed (details follow): svn: Working copy'/kdepim/korganizer/pics' is missing or not locked
>
> I can reproduce it:
>
> $SVN mkdir $REPO/foo $REPO/foo/bar $REPO/foo/baz $REPO/zig $REPO/zig/zag
> $SVN co $REPO/foo wc
> $SVN sw $REPO/zig wc/bar
> $SVN ps x x wc/baz
> $SVN ps x x wc/bar
> $SVN ci wc/baz wc/bar
>
> > I used gdb to debug this a little (for once ;) ), and found out that
> > the problem was that is_wc_root is true for the first path
> > (korganizer), so svn_wc_get_actual_target returns an empty name, so
>
> check_wc_root() does this
>
> /* If PATH's parent in the WC is not its parent in the repository,
> PATH is a WC root. */
> if (entry && entry->url
> && (strcmp (svn_path_url_add_component (p_entry->url, base_name, pool),
> entry->url) != 0))
> return SVN_NO_ERROR;
>
> which means that a switched directory look like a wc root, I think
> that's a bug. Hmmm, if PATH was a switched file it looks like the
> above code would classify the file as a wc root, that's doesn't look
> right either. The check_wc_root function has been around for a long
> time, I'd guess it pre-dates switch altogether.

Hello Philip,
thanks for your followup. Did someone look into fixing this?
Or should I report a bug so that it doesn't get forgotten?

-- 
David Faure, faure@kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 31 12:44:50 2005

This is an archived mail posted to the Subversion Dev mailing list.