[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add --xml to proplist command

From: se˝ior ┐tyrtle? <machtyrtle_at_gmail.com>
Date: 2005-07-28 21:17:50 CEST

On 7/28/05 6:42 PM, "Julian Foad" <julianfoad@btopenworld.com> sneezed:

> I don't know if you were expecting/wanting/not wanting me to do this, but I
> have reworked your patch to produce the attached version.
>
> There are lots of stylistic differences, but also functional differences
> including:
>
> - the DTD is different
>
> - the output from all targets to the "svn proplist" command are contained in
> a single XML document (rather than one per explicit target), as with the other
> commands that output XML.
Wasn't it like that before?..or perhaps I don't fully understand this
sentence.

>
> The major stylistic change I made is:
>
> - I've removed one level of iterator function, as this made things simpler
> in my opinion.
At the cost of performance...in group_props you're checking the 'xml'
boolean in a loop. I also happen to think the code was more extensible with
two iteration function...but I guess this is your call as a maintainer.

> There are more changes I think should be made:
>
> - When displaying rev-props, the target's "path" attribute should be omitted
> because it is irrelevant.
Wouldn't it be the url to the repository... I think that's hardly
irrelevant. 'svn ls --xml' prints the url to the repository.

> - Should probably remove the "value" element, leaving the property's value
> as the sole content of the "property" element. You made a remark about
> putting
> the value in a sub-element but I can't see a real benefit.
Say property-inheritance is implemented sometime in the near future...
<property>
 <value></value>
 <parent>something meaningful here</parent>
</property>

> I'd appreciate comments by anybody on the above changes, and perhaps a review
> of the patch although it won't be the final version. It would be great if you
> want to continue to develop this patch with some of those changes (hmm, I hope
> I haven't changed it so much that you won't like to work on it any more), but
> otherwise I would be happy to do so.
I haven't worked on it in days. I'd be happy to do some more, but feel
pretty strong about the previous two items, so maybe when they're resolved.

I looked through the patch for style issues; alas, I found none.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 28 21:19:00 2005

This is an archived mail posted to the Subversion Dev mailing list.