[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] RA sessions should always be loaded from the same pool

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2005-07-28 00:33:02 CEST

Nix <nix@esperi.org.uk> writes:

> (I still wonder how this ever works on anyone's machine; perhaps a lot
> of OSes tend to put repeatedly dlopen()ed libraries at the same place
> every time?)

I suspect very few people use --enable-dso.

> I'm not sure if the underlying bug here is that the auth baton is
> persisting for too long, or that the DAV library's getting unloaded when
> it shouldn't be (why should a `svn ls' unload it only to load it again?)
> or that the bug is that we should never use string literals in
> dlopen()ed shared libraries...
>
> ... but the latter fix feels wrong somehow.

The auth design generated *huge* threads on the dev list, I certainly
gave up attempting to follow the discussion. I never really
understood why we chose to use a hash to pass parameters.

It's not just the string literals used as hash keys, the hash values
are pointers to data allocated from the pool used to load the dso, so
they will also become invalid once the pool is cleared and the dso
unloaded. I think we should have a pool cleanup function to remove
the key/value pairs from the hash.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 28 00:34:04 2005

This is an archived mail posted to the Subversion Dev mailing list.