Re: [PATCH] RA sessions should always be loaded from the same pool

Nix <nix@esperi.org.uk> writes:

> On Wed, 27 Jul 2005, Philip Martin announced authoritatively:
>> The DSO will get unloaded when the pool used to load it is
>> cleared/destroyed. Does the parameters hash persist longer than the
>> DSO? That doesn't sound right to me, but then the auth stuff has so
>> many layers I gave up trying to follow it some time ago :-(
>
> It feels wrong to me, too, but it appears to outlast the pool used by
> the RA *loader*, which (from experiment ;) ) may not be the same pool.

I gave up trying to follow the auth stuff. However, at around line
720 svn_ra_dav__open calls svn_auth_set_parameter and passes things
allocated from its pool and these get stored in the hash passed via
the callbacks argument, so it looks like the hash could well have a
longer lifetime than the dav session. Perhaps a pool cleanup function
should clear the auth parameters? I wonder if there are other cases
where svn_auth_set_parameter does something similar?

>> I don't think --enable-dso gets much testing during development, the
>> build broke in the run up to 1.2 and it took longer than usual to get
>> noticed.
>
> Well, I never build without it, so if there's blatant breakage I'll
> let you know :)

Interesting, what do you see as the advantage of --enable-dso?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org