[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15423 - in trunk/subversion: libsvn_ra_dav

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-07-27 05:11:02 CEST

Carsten Koch wrote:

> There is no need to apologize for enforcing consistency.
> Just imagine how hard it would be to read the source if
> the personal coding style of 1000 different authors would
> be allowed to go in.

My personal take:

I think we're just a bit over-eager to recruit more core developers.
We're so eager, that we treat every patch submission as if it were sent
by somebody who is working toward earning commit access. Those
standards are high: we expect committers to not only know the codebase,
but also to understand and follow our coding and formatting conventions.

But the fact is, many patches we get are simply ones "thrown over the
wall" by generous folk who have no intention of earning commit access.
When they immediately start getting grilled by the high standards, it
seems like we're ungrateful.

We simply need to be more cognizant of exactly who wrote the patch, and
what sort of feedback is appropriate.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 27 05:11:17 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.