[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 1628

From: Valik <vampirevalik_at_hotmail.com>
Date: 2005-07-26 21:45:06 CEST

> -----Original Message-----
> From: kfogel@collab.net [mailto:kfogel@collab.net]
> Posted At: Tuesday, July 26, 2005 2:24 PM
> Posted To: gmane.comp.version-control.subversion.devel
> Conversation: [PATCH] Issue 1628
> Subject: Re: [PATCH] Issue 1628
> "Valik" <vampirevalik@hotmail.com> writes:
> > This isn't the stone-age anymore. I find it absurd (As I've stated
> > times in this thread) that in 2005, we're having this conversation.
> Write
> > a script/program or find one that cleans up source code formatting
> > don't know any off the top of my head, I'm afraid). Stop the
problem on
> > your end; don't try to push it out to the users who more than likely
> don't
> > care about the project's hang-ups on stylistic issues. I think a
> > Python or Perl script doing some regular expression search/replace
> on
> > a file would stop style issues dead. I think there are even version
> > control software out there that could run such a script in a thing
> called
> > a pre-commit hook. Wouldn't it be nice if you knew where you could
> > VCS like that?
> This suggestion keeps coming up.
> Even just specifying the problem is exceedingly complex, and I am
> pretty sure that writing a tool (or configuring an existing tool) to
> take care of even a majority of the stylistic nits that typically come
> up here would be impossible. I'd love to be proved wrong, but in five
> years no one has written such a tool, and it's not because we wouldn't
> like one, nor because the problem has received no attention. So while
> I appreciate the suggestion, I think it's pretty much hand-waving.
> This problem is Hard.

So you're saying you guys are capable of writing version control
software but can't write or find something to tidy source code? Forgive
the profanity, but bullshit. You're even using C, I believe, which
eliminates a lot of the complexities that would revolve around
templates, classes and namespaces. Writing a tool on your own shouldn't
be more than a couple days work. Of course, why bother when we have our
ubiquitous friend Google to help us out:


I don't know how useful those specific links are as I didn't review them
for content other than they can tidy C code. You can find many more
hits with either of these 2 Google queries that I used:


This is an _easy_ problem to solve, not a hard one. I don't understand
what makes it so hard, other than you've got a misconception in your
head that it is hard. All white space problems can be taken care of by
one of the above programs, I'm sure. Some name issues can be taken care
of via scripts. Hungarian notation should be pretty easy to clean up
via a script. Also, as a general rule, new committers who are less
likely to be concerned about style and variable naming will probably not
be submitting large patches so fixing up variable naming issues should
be a trivial task to do by hand. Larger patches are more likely (Not
always, but more likely) to come from somebody who will pay more
attention to naming.

Incidentally, you say this: "... nor because the problem has received no
attention" but I would argue otherwise. It may have received attention,
but can anybody honestly say they actually put some effort into this? I
found 5 links that appear to be useful or offer software to do what I
describe and I spent as many minutes (or less) on Google looking. You
guys aren't the first project to ever want to maintain code consistency
so leverage other's experiences and find the software they use.

And if all else fails, do it yourself. It can't be any harder than
writing a multi-platform VCS.

- Valik

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 26 21:49:56 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.