Re: When to call svn_repos_abort_report?

Greg Hudson <ghudson@MIT.EDU> writes:

> On Mon, 2005-07-25 at 20:11 +0100, Philip Martin wrote:
>> If svn_repos_finish_report fails and returns an error is it valid for
>> the caller to call svn_repos_abort_report?
>
> I think the answer is no, and svn_wc_crawl_revisions2 is in error.

In practice svn_wc_crawl_revisions2 uses svn_ra_reporter2_t and the
ra_local version forwards to the svn_repos_xxx functions. The ra
functions don't document any abort/finish restrictions at all, I guess
the svn_repos_xxx restrictions apply there as well?

Looking at ra_svn it appears that the client tries to send
"abort-report" after "finish-report" but I think the client closes the
connection before the server (fails?) to process it.

#!/bin/bash

SVN=svn
#SVN=/home/pm/sw/subversion/obj/subversion/clients/cmdline/svn
#REPO=file://`pwd`/repo
REPO=svn://localhost/repo
#REPO=http://localhost:8888/obj/repo
rm -rf repo wc
#svnadmin create --bdb-txn-nosync repo
svnadmin create --fs-type fsfs repo
echo [general] >> repo/conf/svnserve.conf
echo anon-access = write >> repo/conf/svnserve.conf
echo password-db = passwd >> repo/conf/svnserve.conf
echo [users] >> repo/conf/passwd
echo pm = mp >> repo/conf/passwd
echo xx = xx >> repo/conf/passwd

$SVN mkdir $REPO/foo $REPO/foo/bar $REPO/bar
$SVN rm $REPO/foo/bar
$SVN co $REPO/foo wc
$SVN ps svn:externals "bar $REPO/bar" wc
$SVN ci wc
$SVN up wc
$SVN up -r1 wc

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org