Re: [PATCH] diff preview without text deltas

Julian Foad wrote:
> Martin Hauner wrote:
>>
>> attached is a patch which adds new diff preview api calls (which the
>> gui clients like to have) that doesn't produce text deltas.
>
>
> Thanks. I don't have the energy to review this fully. I'm just
> scanning through it and giving whatever comments I can, enough to get
> you going on the next iteration.

Yes, it is quite big, I'm considering splitting it up somehow.
A first step could be the added boolean for do_diff and the version
compatibility.

>> Would you like to see some code to run the preview from "svn" too or
>> will you accept an api only patch?
>
>
> Personally I don't think it's a firm requirement that the command-line
> client should be able to invoke this, but there ought to be some way of
> invoking it for testing purposes - maybe through a dedicated test
> program, or maybe adding an interface to the command-line client is the
> easiest way to do this.

Ok, i already have a small patch that extends svn, I will attach it the
next time.

>> May i change vparse_tuple to ignore an (unspecified) optional boolean?
>
>
> I imagine so, though I'm not at all familiar with that area. Please
> provide a separate patch that does so, that we could apply first.

Ok, I will do so.

>> subversion/libsvn_ra_svn/protocol
>> ---------------------------------
>>
>> should the protocol file be updated?
>
>
> Certainly! Are you volunteering?

Sure.. :)

> [..patch comments..]

I have to look in more detail at your code comments, I need to
familiarize myself again with my patch. ;)

Thanks Julian for your comments.

-- 
Martin
Subcommander, http://subcommander.tigris.org
a cross platform Win32/Unix/MacOSX subversion gui client & diff/merge tool.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org