Re: [PATCH] avoid memory reallocation

Branko Čibej wrote:

>> This is really a *very* little thing:
>>
>> The CL client uses an array to store all the auth providers. The
>> initial size of that array is set to 10, but on Windows, there's one
>> auth provider more so the array is always reallocated (or I'm counting
>> wrong, could happen too).
>> This very little patch takes care of this.
>
>
> Perhaps it does, but why bother? Do you propose we change the initial
> size of the array every time we add an auth provider. So the
> reallocation may be ugly, but it doesn't affect the behaviour of the
> client in any measurable way.

Well, I don't think that you'll be adding new auth providers every few
days, so adjusting the initial size of the array is really not too much
work. And sure, it doesn't affect the behaviour of the client at all,
but as you said it's ugly. After all, the initial size is set to 10 - if
you don't care about reallocation you could have chosen 1 for that
initial size.

Anyway, if you don't like it, don't use it.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org