[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 1628: use a custom crash handler on Windows

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-07-25 17:05:01 CEST

Julian Foad wrote:

> Branko Čibej wrote:
>
>> Servers usually run unattended.
>
>
> Well, how about using this crash-reporting DLL in just the client-side
> programs for now? That would avoid the need for a substantial amount
> of additional design and coding right now, and get us more than half
> the benefit (clients being more numerous, more complex, and more
> varied in their usage patterns than servers).
>
> The server-side requirements can be considered later.

I had thought of that. Doing so would of course mean that the patch has
to change a bit, since putting the loading into svn_cmdline_init would
no longer be appropriate (that function is called by all command-line
tools, including svnserve). That requires a new public API to set up
crash reporting, and that API would need at least a parameter (not used
yet) throught which you'd tell it if you want online (i.e.,
dialogue-based) reporting of offline (file-based) reporting.

We'd also need a small change in "almost every" command-line tool so
that it calls the new function in addition to svn_cmline_init. (Or
perhaps insted of, if the new function is a wrapper for the old one?
Maybe we could even do it by revving to svn_cmdline_init2?).

I'd find this solution acceptable.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 25 17:08:25 2005

This is an archived mail posted to the Subversion Dev mailing list.