[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn trunk r15420: FAIL (win32 ra_local fsfs)

From: D.J. Heap <dj_at_shadyvale.net>
Date: 2005-07-25 15:17:45 CEST

The Win32 tests are failing in repos authz tests again due to the same
problem I fixed a few weeks ago -- the temp config file cannot be opened by
the config parsing routines because they don't use APR and on Win32 stdio
wants an exclusive lock on the file.

Previously, I fixed it by changing the test to manually close and delete the
file so it would be available for the config routines. However, it seems
like it may be better to just fix the config parsing to deal with different
types of line endings and make it use APR so this type of problem doesn't
come up any more. I haven't looked at it really closely to determine how
hard that would be.

Any thoughts or opinions on whether to just fix the test, or to change the
config parsing code to use APR and deal with different line endings?

Fixing the test is much simpler, but seems prone to re-introduction again
(whether in tests or in production). I'm not an expert on the config
parsing code, but if servers are going to use it they could have a
concurrency problem unless some sort of another ugly retry-loop is used,
couldn't they?

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 25 15:21:47 2005

This is an archived mail posted to the Subversion Dev mailing list.