[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue 1628

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-07-25 09:40:19 CEST

Mark Phippard wrote:

>Branko Čibej <brane@xbc.nu> wrote on 07/24/2005 08:27:00 PM:
>
>
>
>>I think you're wrong about svnserve not restarting -- it can and will,
>>if it's wrapped with some kind of service wrapper.
>>
>>But more important: we're talking about server administration here.
>>Servers usually run unattended. The biggest pain in the ass about
>>Windows (as a server OS) is that 99% of the server software running on
>>it assumes that someone will always monitor the server through a GUI.
>>Your crash report code even assumes that the box actually has a mail
>>client installed.
>>
>>An administrator can view the event log remotely (without a GUI login),
>>and can get at files on the server remotely.
>>
>>
>>The patch itself is almsot there, I only counted one tab, a few cases of
>>
>>
>
>
>
>>hungarian notation, and some funny indentaion and space-before-paren not
>>
>>
>
>
>
>>consistent with the rest of the file.
>>
>>But before we go and iron out these nits, let's solve the problem of the
>>
>>
>
>
>
>>format of the crash reports themselves, please.
>>
>>
>
>I have to say, if I were Stefan I would be a bit frustrated right now.
>This is how I see what has happened here.
>
>Stefan submits a code example based on how he has integrated this feature
>into TortoiseSVN. He makes is pretty clear that he is not submitting a
>patch to be applied as is, but rather a suggestion as to a possible way to
>solve this issue.
>
>His submission gets picked apart repeatedly over style issues with
>virtually no mention of the technical details and merits of the approach.
>Only after he resubmits it several times correcting said style issues is
>it now brought up that this approach has some significant areas that would
>need to be addressed.
>
>
I really must respond, because I /did/ discuss technical issues from the
start. Of course I could not ignore the stylistic side, because even a
technically perfect patch wouldn't be accepted if style wasn't correct.

It's true I didn't mention all the technical issues I raised in my first
response. That's because I simply didn't think of them. But I certainly
see the techincal side as being more important than the stylistic side;
if I didn't, I'd have made the final tweaks myself and committed the
patch by now.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 25 09:41:17 2005

This is an archived mail posted to the Subversion Dev mailing list.