[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add --xml to proplist command

From: <kfogel_at_collab.net>
Date: 2005-07-23 06:32:44 CEST

David Anderson <david.anderson@calixo.net> writes:
> se˝ior ┐tyrtle? wrote:
> > Thanks for the quick review.
>
> Just a quick note as Julian seems to be covering the rest: use the
> present tense in your log messages, for consistency with other log
> messages. So "Modified" -> "Modify", "Added" -> "Add" (actually,
> that's "Added" -> "New" :-) ), etc.
>
> Obviously, stick to the past tense when talking about how things were
> before your patch. Just describe your changes in the present tense.

Oh dear, it may be that I've succeeded in transmitting some of the
worst aspects of my personality to the project :-). I think I'm
probably responsible for the unusual focus on verb tense around here,
so allow me to do a little penance...

To clarify:

I totally agree with Dave that present tense is preferable, and have
often made the same comment when reviewing patches. But, please don't
think that such a thing would ever prevent us from applying a patch.
Plenty of log messages in Subversion have past-tense verbs, and anyway
it's easy for the committer to tweak this at commit time. So Dave's
advice is good, but don't interpret it as "You must do this or your
patches will be rejected". While we notice the small things, we try
not to let them stand in the way of getting real work done (I hope!).

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 23 07:24:35 2005

This is an archived mail posted to the Subversion Dev mailing list.