[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add --xml to proplist command

From: señior ¿tyrtle? <machtyrtle_at_gmail.com>
Date: 2005-07-22 23:51:10 CEST

Thanks for the quick review.

[[[
Added support for "svn proplist" to print in xml.
   
* subversion/subversion/clients/cmdline/cl.h:
   (svn_cl__print_prop_hash): Remove declaration.
   It was only being used in proplist-cmd.c, and
   needed to be re-factored to print different formats.

* subversion/subversion/clients/cmdline/props.c:
   (svn_cl__print_prop_hash): Remove.

   * subversion/subversion/clients/cmdline/proplist-cmd.c:
   (svn_cl__proplist) Modified to test for opt_state->xml and acts
accordingly.
     -verbose switches between absolute and relative paths for xml.
   (print_prop_array) Added, based on (svn_cl__print_prop_hash).
   (print_prop_hash) Added, moved out from (svn_cl__proplist).
   (print_prop_xml) Added, prints a single property in xml.
   (print_prop_cl) Added, prints a single property to command-line.
   (group_props_xml) Added, prints a group of properties to xml.
   (group_props_cl) Added, prints a group of properties to xml.
   (begin_xml_proplist) Added. Start a property list xml stringbuf.
   (end_xml_proplist) Added. End a property list xml stringbuf.

* subversion/subversion/clients/cmdline/main.c:
   (svn_cl__cmd_table) Add svn_cl__xml_opt for proplist command.
]]]

> What if the property value is not UTF-8? This would produce invalid XML. Do
> you have any ideas about what we should do in that case?

I'm using svn_xml_is_xml_safe to test and encode to base64 on failure.
It's working well here with binary/non-binary props...but there is the weird
case of binary data actually being legal xml.

> Missing ">" and ".". Wrapper for what? Ideally, say how the arguments are
> used (e.g. does it append to any string that might already be in "sb"?).
Sorry wrapper was a bad word choice..grouping is better.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Fri Jul 22 23:52:51 2005

This is an archived mail posted to the Subversion Dev mailing list.