Re: [PATCH] remove textdomain()

Kouhei Sutou wrote:
> We can remove textdomain(PACKAGE_NAME) by replacing all
> gettext(x) with dgettext(PACKAGE_NAME, x).
>
> textdomain(PACKAGE_NAME) sets PACKAGE_NAME to the current
> message domain. This is not good thing for svn library
> users. Some users who assume that their current message
> domain is MY_PACKAGE_NAME may get some troubles.
>
> And gettext(x) call may cause some troubles when svn library
> user changes the current message domain to MY_PACKAGE_NAME.

I don't know much about "gettext" but this sounds like a good idea.

>
>
> [[[
> Remove textdomain(), gettext() and dgettext(). Use _()
> instead of gettext() and dgettext().

Please state the purpose of the change first, before (or instead of) giving
these implementation details.

> * subversion/include/svn_nls.h (svn_nls_environment_init),
> * subversion/libsvn_subr/nls.c (svn_nls_environment_init):
> Rename to svn_nls_init() and override.

You can't just rename a public API function if it has been in a released
version: you have to deprecate it instead.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 22 15:21:49 2005