[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] truncate EDITOR_EOF_PREFIX with previous EOL

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2005-07-20 16:12:15 CEST

Olleg Samoylov wrote:

> Yes, I take exactly same code to detect EOL from current source.
> But may be better use apr_isspace(char)? And remove not only EOL but
> trailing space also?

Actually, since the log messages are in UTF-8, you should be using the
svn_ctype macros everywhere, including when you check for \r and \n (and
so should the rest of the code, of course -- we still have lots of
places where we don't behave nicely).

-- Brane

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 20 16:16:05 2005

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.