[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Links to mailing list threads in commit messages (was: svn commit: r15371 - branches/python-bindings-improvements/subversion/bindings/swig/python/libsvn_swig_py)

From: David James <james82_at_gmail.com>
Date: 2005-07-20 04:42:27 CEST

Do you think it's good to include a link to a mailing list thread in a
commit message? I've included an example below.

Cheers,

David

On 7/19/05, djames@tigris.org <djames@tigris.org> wrote:
> Author: djames
> Date: Tue Jul 19 21:20:28 2005
> New Revision: 15371
>
> Modified:
> branches/python-bindings-improvements/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
>
> Log:
> Convert poolAttribute, assertValid, and emptyTuple from casted
> "char *" variables into "char[]" variables so as to avoid
> unsafe casts.
>
> Patch by: David James <james@cs.toronto.edu>
> Thread: http://svn.haxx.se/dev/archive-2005-07/0796.shtml
> Suggested By: Philip Martin <philip@codematters.co.uk>
> (Thanks Philip! Good catch!)
>
> subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c:
> (Automatic Pool Management Functions): Convert poolAttribute,
> assertValid, and emptyTuple from (char *) variables into char[]
> variables.
>
>
>
> Modified: branches/python-bindings-improvements/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
> Url: http://svn.collab.net/viewcvs/svn/branches/python-bindings-improvements/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c?rev=15371&p1=branches/python-bindings-improvements/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c&p2=branches/python-bindings-improvements/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c&r1=15370&r2=15371
> ==============================================================================
> --- branches/python-bindings-improvements/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c (original)
> +++ branches/python-bindings-improvements/subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c Tue Jul 19 21:20:28 2005
> @@ -113,9 +113,9 @@
>
> /* The application pool */
> apr_pool_t *_global_pool = NULL;
> -static char *poolAttribute = (char *) "_pool";
> -static char *assertValid = (char *) "assert_valid";
> -static char *emptyTuple = (char *) "()";
> +static char poolAttribute[] = "_pool";
> +static char assertValid[] = "assert_valid";
> +static char emptyTuple[] = "()";
>
>
> /* Set the application pool */
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
>
>

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 20 04:43:34 2005

This is an archived mail posted to the Subversion Dev mailing list.