crash when locking a file (client 1.2.1, repository 1.1.x)

Hi,

Another one spotted by a TSVN user who sent a crashreport:

Subversion crashes when a lock is attempted on a file whose working copy
is hosted on a 1.1.x server.

Reproducable every time with my 1.2.1 build of the Subversion CL client
on WinXP SP2:

> cd TortoiseSVN # my working copy of TSVN
> svn lock build.bat
now I'm asked three times for authentication. And I'm sure I'm giving
the correct username/password every time!
Then, the crash happens.

The crash happens in libsvn_subr/auth.c, line 320:

   /* First, try to save the creds using the provider that produced them. */
   provider = APR_ARRAY_IDX (state->table->providers,
                             state->provider_idx,
                             svn_auth_provider_object_t *);
   if (provider->vtable->save_credentials)

in the last line, the 'provider' is NULL. So I suggest changing
- if (provider->vtable->save_credentials)
+ if ((provider)&&(provider->vtable->save_credentials))

But it might also help to find out why the authentication failed -
there's something wrong there too which I couldn't find out.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org