[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15343 - in trunk/subversion: libsvn_subr

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2005-07-19 14:51:56 CEST

Hi,

In <42DCB814.2030003@xbc.nu>
  "Re: svn commit: r15343 - in trunk/subversion: libsvn_subr" on Tue, 19 Jul 2005 10:21:40 +0200,
  Branko ╚ibej <brane@xbc.nu> wrote:

> >What about the new patch?
> >
> Looks O.K., except for one nit:
>
> >- if (error == SVN_NO_ERROR)
> >+ if (err == SVN_NO_ERROR)
> >
> >
> SVN_NO_ERROR is NULL by definition. we usually test this as "if (!err)"

I see.
Could you fix this problem and commit the patch if you
approve the patch?

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 19 14:52:53 2005

This is an archived mail posted to the Subversion Dev mailing list.