[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15343 - in trunk/subversion: libsvn_subr

From: Branko Čibej <brane_at_xbc.nu>
Date: 2005-07-18 12:01:58 CEST

Kouhei Sutou wrote:

>@@ -87,10 +87,10 @@
> apr_err = APR_INCOMPLETE;
> if (apr_err)
> {
>- error = svn_error_create(apr_err, NULL,
>- _("Can't convert module path "
>- "to UTF-8 from UCS-2: '%s'"),
>- ucs2_path);
>+ err = svn_error_create(apr_err, NULL,
>+ _("Can't convert module path "
>+ "to UTF-8 from UCS-2: '%s'"),
>+ ucs2_path);
>
>
This should be svn_error_createf.
Another thing: this file uses the space-before-paren-in-function-call
style, which you don't follow consistently. Please fix this.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 18 12:03:12 2005

This is an archived mail posted to the Subversion Dev mailing list.