[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r15351 - trunk/subversion/libsvn_client

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-07-17 22:57:32 CEST

On Sat, 16 Jul 2005 sussman@tigris.org wrote:

> Author: sussman
> Log:
> Client bugfix: make 'svn st -u' work against a pre 1.2 mod_dav_svn.
>
> * subversion/libsvn_client/status.c
> (reporter_finish_report): look for 'unimplemented' error code
> thrown by *both* mod_dav_svn and svnserve, just like
> svn_client_info() does.
>
>
> Modified: trunk/subversion/libsvn_client/status.c
> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/libsvn_client/status.c?rev=15351&p1=trunk/subversion/libsvn_client/status.c&p2=trunk/subversion/libsvn_client/status.c&r1=15350&r2=15351
> ==============================================================================
> --- trunk/subversion/libsvn_client/status.c (original)
> +++ trunk/subversion/libsvn_client/status.c Sat Jul 16 11:06:56 2005
> @@ -147,7 +147,8 @@
> server doesn't support lock discovery, we'll just not do locky
> stuff. */
> err = svn_ra_get_locks (ras, &locks, "", rb->pool);
> - if (err && err->apr_err == SVN_ERR_RA_NOT_IMPLEMENTED)
> + if (err && ((err->apr_err == SVN_ERR_RA_NOT_IMPLEMENTED)
> + || (err->apr_err == SVN_ERR_UNSUPPORTED_FEATURE)))
Ahem! Why not make *both* RA layers return the same error instead like
svn_ra_get_locations and svn_ra_get_file_revs do? They are even
*documented* to return NOT_IMPLEMENTED in the public API, which the
locking RA functions aren't

Regards,
//Peter Busy Having Holiday Lundblad;)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jul 17 22:58:13 2005

This is an archived mail posted to the Subversion Dev mailing list.