[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Change Default Client Credentials Caching

From: Thorsten Haude <linux_at_thorstenhau.de>
Date: 2005-07-15 23:12:47 CEST

Hi,

we have a problem with Client Credentials Caching, and we want to
patch Subversion to default to off here (which should be default).

I browsed the source a bit and think I have to change this in three
places (1.2.0):
- - - Schnipp - - -
--- main.c 2005-06-22 19:17:33.574903000 +0200
+++ main.c.old 2005-06-22 19:17:04.009793000 +0200
@@ -1325,11 +1325,11 @@
      subcommands will populate the ctx->log_msg_baton */
   ctx->log_msg_func = svn_cl__get_log_message;

   /* Authentication set-up. */
   {
- svn_boolean_t store_password_val = FALSE;
+ svn_boolean_t store_password_val = TRUE;
     svn_auth_provider_object_t *provider;

     /* The whole list of registered providers */
     apr_array_header_t *providers
       = apr_array_make (pool, 10, sizeof (svn_auth_provider_object_t *));
@@ -1407,22 +1407,22 @@
                              opt_state.config_dir);

     if ((err = svn_config_get_bool (cfg, &store_password_val,
                                     SVN_CONFIG_SECTION_AUTH,
                                     SVN_CONFIG_OPTION_STORE_PASSWORDS,
- FALSE)))
+ TRUE)))

       svn_handle_error (err, stderr, TRUE);
     if (! store_password_val)
       svn_auth_set_parameter(ab, SVN_AUTH_PARAM_DONT_STORE_PASSWORDS, "");

     /* There are two different ways the user can disable disk caching
        of credentials: either via --no-auth-cache, or in the config
        file ('store-auth-creds = no'). */
     if ((err = svn_config_get_bool (cfg, &store_password_val,
                                     SVN_CONFIG_SECTION_AUTH,
                                     SVN_CONFIG_OPTION_STORE_AUTH_CREDS,
- FALSE)))
+ TRUE)))
       svn_handle_error (err, stderr, TRUE);
     if (opt_state.no_auth_cache || ! store_password_val)
       svn_auth_set_parameter(ab, SVN_AUTH_PARAM_NO_AUTH_CACHE, "");
   }
- - - Schnipp - - -

Question:
1a) Is this sufficient to switch off the default caching of client
    credentials?
1b) Is there a better way?
 2) In case we decide to disallow client credentials caching entirely:
    What would be the best way to do this?

Thanks in advance for your help, and thank you very much for a great
tool!

Thorsten

-- 
Der Optimist ist in der Regel ein Zeitgenosse, der ungenügend informiert ist.
    - John B. Priestly

  • application/pgp-signature attachment: stored
Received on Fri Jul 15 23:15:31 2005

This is an archived mail posted to the Subversion Dev mailing list.