[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] HACKING - add triple square brackets

From: Michael W Thelen <mike_at_pietdepsi.com>
Date: 2005-07-15 18:47:18 CEST

Gábor Szabó wrote:
> As per the request of Karl here is the patch
> Actually I was not sure if I should rearrange the lines following
> the example and thus making the patch larger but keeping the
> full lines or leave a half line there. for now I left there the half line.

Thanks for the patch! I think it's probably better to reflow the lines,
even if the patch is larger.

> Index: HACKING
> ===================================================================
> --- HACKING (revision 15335)
> +++ HACKING (working copy)
> @@ -1140,7 +1140,15 @@
> instead.
>
> The email message should start off with a log message, as described in
> -"Writing log messages" above. The patch itself should be in unified
> +"Writing log messages" above. It should be enclosed in triple square
> +brackets just like this:
> +
> + [[[
> + * HACKING
> + Improving the patch submission guidelines
> + ]]]
> +

This log message needs a colon after HACKING. It might also be nice to
use one of the log messages shown in the "Writing log messages" section,
for continuity:

   [[[
   Fix issue #1729: Don't crash because of a missing file.

   * subversion/libsvn_ra_ansible/get_editor.c
     (frobnicate_file): Check that file exists before frobnicating.
   ]]]

> +The patch itself should be in unified
> diff format (e.g., with "svn diff"). Send the patch as an attachment,
> with a mime-type of text/x-diff, text/x-patch, or text/plain. (Most
> people's mailreaders can display those inline, and having the patch as

-- 
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 15 18:48:14 2005

This is an archived mail posted to the Subversion Dev mailing list.