[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: libsvn_repos logging -- design problems

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2005-07-15 18:04:41 CEST

On Fri, 2005-07-15 at 11:53 -0400, John Peacock wrote:
> It would also solve the apr_psprintf performance issues if there was an
> opaque logger object that contained the loglevel, so that all code could
> do something like this [horrible pseudocode]:
>
> if this_event_level < logger.loglevel
> logger.log_error(moderately expensive apr_psprintf)
>
> thus making it completely natural to avoid a potentially expensive test,
> as well as remove the need for each place to cache the loglevel
> individually.

I'm baffled by this argument. We can do exactly the same thing in Ben's
API, except that logger.loglevel is a function call. But you proposed
that the logger be an "opaque" object, so presumably logger.loglevel
would also be a function call.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 15 18:06:23 2005

This is an archived mail posted to the Subversion Dev mailing list.