[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] extract NLS initialization code form svn_cmdline_init

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2005-07-12 03:55:05 CEST

Kouhei Sutou wrote:
> Hi,
>
> In <42D0B272.40101@electricjellyfish.net>
> "Re: [PATCH] extract NLS initialization code form svn_cmdline_init" on Sat, 09 Jul 2005 22:30:26 -0700,
> Garrett Rooney <rooneg@electricjellyfish.net> wrote:
>
>
>>>How about the attached patch?
>>
>>Looks pretty good. I've included a few comments inline.
>
>
> Thank you for your feedback.
>
> I remake a patch applied your comments and attach this.
>
> {{{
> Extract NLS initialization code from svn_cmdline_init.
>
> * subversion/libsvn_subr/nls.c
> (svn_nls_environment_init): Initialize NLS environment.
> (svn_nls_init): Initialize NLS environment and set up
> text domain.
>
> * subversion/include/svn_nls.h: Add.
>
> * subversion/libsvn_subr/cmdline.c
> (svn_cmdline_init): Extract NLS initialization code.
> }}}
>
>
> By the way, I have an anxiety. The codes are *not* tested on
> WIN32 environment because I don't have the
> environment. Could someone test the codes on WIN32
> environment?

+1, although I would also like to see someone test this on win32 if
possible, although if you don't get a reply from anyone within the next
day or two I'd say just commit it, it's just moving existing code
around, and in the unlikely event that it breaks something I imagine
we'll know reasonably quickly.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 12 03:56:41 2005

This is an archived mail posted to the Subversion Dev mailing list.