[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Trivial patches?

From: <kfogel_at_collab.net>
Date: 2005-07-09 21:19:29 CEST

"Jonathan Gilbert" <o2w9gs702@sneakemail.com> writes:
> At 03:00 PM 08/07/2005 -0700, Matthew Janulewicz wrote:
> >Maybe make a patch for some other functionality and slip that in as a
> >rider. ;)
>
> Isn't this the polar opposite of the best practice? Patches should address
> a single issue, even if that issue is a 1 character grammatical correction...

Careful, those are two different practices there.

Yes, a patch should be about one thing, and not include unrelated changes.

No, a patch for a 1 character typo is not necessarily worth the time.

> I don't know how religiously SVN is following this practice, but I know of
> other projects where you could practically be hung for slipping in an
> unrelated fix with a patch. For instance, the mono project regularly
> rejects patches that alter whitespace, even if only 1 line is affected and
> the patch contains significant changes nearby (they require the author to
> correct the patch so that it does not alter any existing whitespace at all).

We pretty much follow this practice too.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jul 9 22:08:05 2005

This is an archived mail posted to the Subversion Dev mailing list.